Skip to content
This repository has been archived by the owner on Feb 24, 2021. It is now read-only.

Opened Wiki #541

Open
VLoub opened this issue Jan 17, 2020 · 8 comments
Open

Opened Wiki #541

VLoub opened this issue Jan 17, 2020 · 8 comments

Comments

@VLoub
Copy link

VLoub commented Jan 17, 2020

Hello,

I found second MS repo with opened wiki for public update.
dsccommunity/ComputerManagementDsc#296 (comment)

I like DSC and implementing it but i am not sure if GitHub wiki should be my source now 👎

Could some one check rest of them?

Thanks

@PlagueHO
Copy link
Contributor

PlagueHO commented Jan 17, 2020

Hi @VLoub - thanks for raising this. I fixed this a few days ago after it was raised over there. Can you confirm if it is fixed?

I did also check the other ones I maintain. @johlju , @X-Guardian - you might want to check yours. I think there aren't too many more that have Wikis.

@PlagueHO
Copy link
Contributor

PlagueHO commented Jan 17, 2020

I did check ActiveDirectoryDsc and SQLServerDsc as well and it did have the Wiki open. As I have permissions I'll go through and check them myself. Actually many of them have it open. So I'm correcting them.

@johlju
Copy link
Contributor

johlju commented Jan 18, 2020

What setting is this? Is this a setting that need to be set on new repositories we create or is it secure by default? If not we should document this (I can fix that) under https://dsccommunity.org/guidelines/administration#create-github-repository.

@X-Guardian
Copy link
Contributor

https://help.github.com/en/github/building-a-strong-community/changing-access-permissions-for-wikis.

I'm sure these were restricted when they were under the PowerShell account.

@johlju
Copy link
Contributor

johlju commented Jan 18, 2020

I’m not sure it was. Not for all repos. But @PlagueHO seemed to have gone through them all and enabled this. Just wonder if this setting is set by default when creating a new repo.

@johlju
Copy link
Contributor

johlju commented Jan 18, 2020

The link said it is only collaborators that are allowed to edit the wiki by default, so we don’t have to worry about this for new repos.

@PlagueHO
Copy link
Contributor

It seemed to be most repos had the Wiki public, except for the ones that have had a Wiki for a while. The exception being ComputerManagementDsc. So I'm not exactly sure when/what caused the setting to not be set.

@johlju
Copy link
Contributor

johlju commented Jan 18, 2020

I'm guessing this setting was not default secure (or even available) to begin with when the repos was created several years ago, like Wikipedia. 🤔 Anyway, good that they have this setting enabled now. Once the repos can support the auto-doc there is no need for anyone to edit the wikis.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants