-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
faint color attribute "leaks" to the whole command line #1888
Comments
Indeed, this seem to be directly related to: |
@LuanVSO Thanks for reporting the issue. Font effects are not reset properly for most of the token colors, such as the |
maybe related to #1110 |
Update: interesting nugget I just learnt: Without the Module loaded, PowerShell knows no history! 😱 It is like it not only goes colour-blind but also has amnesia 😄 |
@DEberhardt Thanks for reporting the issue. I took a look and it turns out the bleed-through problem for the repro |
@daxian-dbw |
@eabase Got it, and sorry for the not-so-good experience. I will file an issue in the PS repo about this, but I guess this particular issue will be considered "won't fix" given what I explained above. |
Hmm, too bad. Because a few months ago I was checking the PS code for another color problem, and I discovered they are using RegEx's to find and filter ANSI codes... (Sorry, i don't recall exactly where i found that.) But I do know it's pretty bad practice, since its extremely easy to make mistakes with overly eager/hungry regex's, which almost always break when people start using different character sets and terminal coding, such s UTF-8/16/32 etc. |
@eabase It would be great if you can find where that is and why the code is doing so. PowerShell formatting code shouldn't care about ANSI sequences as I understand, but I may be wrong. |
The implementation doesn't use regex though. |
Sorry, I don't recall where I found it. Maybe my memory fail me, because I found my own comment here:
In addition, please check this assumption:
|
That assumption is correct. The |
Are you sure? What happens if the |
@eabase Sorry for the loooong silence here 😓 The |
🎉 This issue was addressed in 2925, which has now been successfully released in |
Environment
Exception report
Steps to reproduce
run
and then type a command line with some parameters
Expected behavior
only the command gets the faint color
Actual behavior
the faint color attribute is never reset which results in the hole command line being faint
The text was updated successfully, but these errors were encountered: