Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Fix Exception when trying to analyze custom attribute that is being defined in different file #995

Closed
wants to merge 2 commits into from

Conversation

bergmeister
Copy link
Collaborator

@bergmeister bergmeister commented May 9, 2018

PR Summary

Fixes #966
This is a quick fix. I would like to understand more details of it. If the definition is not part of a file being analysed by PSSA or know to PowerShell then we cannot do anything. But maybe I can improve the overall pre-analysis or something else.
A test is to be written.

PR Checklist

Note: Tick the boxes below that apply to this pull request by putting an x between the square brackets. Please mark anything not applicable to this PR NA.

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • User facing documentation needed -> Maybe tell the user to load as many definitions as possible into the PowerShell sessions first
  • Change is not breaking
  • To be done. Make sure you've added a new test if existing tests do not effectively test the code changed
  • This PR is ready to merge and is not work in progress
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready

@bergmeister bergmeister changed the base branch from development to master June 13, 2020 18:08
@rjmholt rjmholt marked this pull request as draft April 21, 2021 21:14
@hubuk
Copy link
Contributor

hubuk commented Apr 23, 2021

May be closed as handled in #1659

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exception occurred while constructing custom validator attribute.
2 participants