-
Notifications
You must be signed in to change notification settings - Fork 500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add button with Clear Terminal next to Trash Can or similar place #1651
Comments
This sounds like something VSCode would need to add |
@PrzemyslawKlys this seems like a potentially good feature enhancement but it will have to come from VSCode, can you open an issue there? |
If an API were made available for this, it might be possible to rebind The current behaviour just scrolls to the bottom right? Is there a reason for wanting to erase the terminal, rather than just having things scroll off screen? I ask just because it might be significant effort for a small value add. |
There are 2 problems with the current implementation:
I constantly move things around, depending on how long the output is. While 2nd issue can't be fixed with Clear-Host the first one can. Just to add, I understand the complexity of it and I've already bound my Logitech G mouse button to ALT+CTRL+SHIFT+C which is Terminal Clear for me so I essentially have what I asked for in a personal way. Still a proper implementation and behavior like in ISE, PowerShell Console would be best. |
I recently realized this would actually be really easy to change without even touching any commands.
I would say we should leave this to xterm.js but it's already been quite awhile since this was initially reported and I've heard a few people refer to this as a blocker for switching from the ISE. |
That makes sense. If we down that route we should finally properly implement editor capabilities so that a client (not the user) could specify |
I was thinking about this again and it struck me that the host is usually beyond PowerShell's control except for an API; we really shouldn't have to do anything special with Does |
@rjmholt Yes it does. |
forgive me I have not been keeping up on the clearing issue in xtermjs. The problem here is actually winpty: P.S. Clearing on unix in PowerShell or bash simply scrolls... so I don't think we'll ever have the experience you want on non-Windows. |
It does the same thing in and out of PSIC, it's definitely a xterm.js thing (or a nodepty thing?). There's an issue somewhere discussing it. My idea was to send a custom LSP event that the client could listen for and invoke a custom command to "properly" clear the terminal. Also I agree that we shouldn't have to do anything special, but I'm not sure it'll ever be fixed in that case. |
Before we go down this route of making a new message, I want to see some more data that this is THE issue blocking people from switching. Anything that we do to support this would be a workaround - not a feature. @PrzemyslawKlys I understand your frustration here - but it makes me very uneasy to implement workarounds like this. I think you should open an issue on VSCode to add a "Clear" button next to the trash can that would do the clearing. I'm pretty sure other IDEs have done similar things. ... at least until winpty fixes the underlying issue. |
@TylerLeonhardt to be honest I don't need it. I fixed my G button on my mouse so I explicitly can use this. I would like to have Clear-Host working properly but if it can't be fixed, it can't be fixed. Related items: |
Summary of the new feature
As you know currently using CLS/Clear-Host doesn't bring any joy due to xtermjs implementation.
One way to workaround this is to use Terminal: Clear from VSCode commands
Would be cool if you would be able to add this in a button form somewhere in there (could be largest button possible if you ask me)
Or possibly bind Clear-Host / CLS with that command magically making it work.
The text was updated successfully, but these errors were encountered: