Font Awesome 5 missing symbol git up arrow symbol

[thevtm]

First of all, this theme is awesome. 😄
I've managed to find a little bug when using Font Awesome 5.

Expected Behavior

(Font Awesome 4)

Actual Behavior

(Font Awesome 5)

Specifications

POWERLEVEL9K_MODE='awesome-fontconfig'
ttf-font-awesome 5.0.2-1
zsh 5.4.2
Linux version 4.14.15-1-ARCH

[bhilburn]

@thevtm - Thanks so much for the kind remark! I'm glad you like it =)

Ah, interesting. So, just to be sure, the only difference between those two screenshots is the Font Awesome version? It looks like they change a codepoint on us in the recent version. This is actually rather a pain for us, because we don't really have a way of changing the codepoint based on font version (which P9k doesn't know).

[thevtm]

I'm pretty sure the version is the issue.

Have you considered doing something like POWERLEVEL9K_MODE='awesome5-fontconfig'.
I could work on it.

[flohw]

Hello there !
I can confirm what @thevtm mention. I removed my font awesome 5 related files and add the font awesome 4 ones this fixed the problem.
FontAwesome 5 provides multiple formats for web (ttf, svg, eot, woff, woff2) and a version for desktop as the directory name suggest (use-on-desktop) I tried with the web format and desktop format, same problem : up arrow is incorrect.

Font awesome version 5.0.6

[weilbith]

@bhilburn
As u mentioned, handle different font versions is not possible (isn't it?). I've also a huge interest into this, cause I run into similar issues with nerdfont. So far I often have to define my own segment, to get around these ugly literals.

So here just an approach how to handle this problem in general. Some segments support to define ur own icons. I was rly happy to use them, just to get around this problem.
If we just add the possibility to let the user overwrite each entry in the icon function, everyone can tackle this problem himself.
This approach should have a minimal effort, but provide high flexibility.

If this approach should get attention here and is acceptable, I could do it on my own in a PR, if u like so.

[dritter]

@weilbith This is already possible!
If you type get_icon_names into your shell, you get a list of all icons and the according variable.

Looks like this:

Just declare the variable with your new icon.

On second thought:
We already have kind of "inheritance" in icons. For instance the flat mode "inherits" the icons from awesome-patched. But I am not a fan of this practice:

• flat mode might be interesting for other base icon sets, not just awesome-patched.
• Icon sets for different Font versions might work, if these versions are widely used or have only few changes. Otherwise we would have to support tons of icons, and at least adding new icons would be a pain. In a browser world where you have statistics about the most used browsers an approach like "support latest two versions of most used browsers" might work, does not in a Shell world (no stats). If we take merely nerdfonts as example: Should we support every combination of icon sets? We went with supporting the complete version only (See Icons: The Masterplan #97 (comment) and Wrong codepoints for Octoicons ryanoasis/nerd-fonts#34 for more background infos).

[weilbith]

@dritter
Wow, its actually rly simple. I missed that the function print_icon doesn't do much more then searching for such a variable. Sry for that asininity.

[dritter]

@weilbith Actually, giving the user the opportunity to overwrite icons is the main purpose of print_icon. ;) This is why we changed all simple outputs of icons to that function.
And no need for self-shaming. Making all icons overwritable is a great idea. Only drawback is that we made it quite cryptic (too much magic involved).

[bhilburn]

Sounds like everything is all set, here! If there are still issues, please let us know!

[ImtiazEpu]

Why php icon is missing??