Skip to content
This repository has been archived by the owner on Apr 24, 2020. It is now read-only.

Add fallback icon for missing linux distro icons #936

Closed
eloo opened this issue Jul 30, 2018 · 4 comments
Closed

Add fallback icon for missing linux distro icons #936

eloo opened this issue Jul 30, 2018 · 4 comments

Comments

@eloo
Copy link
Contributor

eloo commented Jul 30, 2018

Describe Your Issue

I've just updated to the latest version of the theme and now my OS_ICON is broken.
I'm using a Debian and now the icon is only "Deb" instead of the Tux icon.
I guess it would be great that at least for fonts which are containing the Tux icon this Icon will be used instead of a simple string.
What do you think?

Environment Information

This information will help us understand your configuration.

  • Debian
  • Font: source code pro + powerline awesome
  • Font-Mode: awesome-patched
@dritter
Copy link
Member

dritter commented Aug 9, 2018

Hi @eloo !

Sorry for the late response. I agree that, as we add more fine-grained control over the Linux icons in Nerd-Fonts, it feels like a bug for other fonts to fall back to a textual representation. That is probably why we get more and more bug reports like this..

Long story short: Would you mind creating a PR for that?

@eloo
Copy link
Contributor Author

eloo commented Aug 10, 2018

yes i can.
i hope i will find time on the weekend for that

@eloo
Copy link
Contributor Author

eloo commented Aug 11, 2018

@dritter
Pull-reqest is open
#951

@dritter dritter mentioned this issue Aug 11, 2018
@bhilburn
Copy link
Member

Merged into master as part of #944! Will be in the v0.6.6 release.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants