-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
slideshow: update image template for managed directories #2156
Conversation
Long post just now on Without any testing, a question. How do the images behave with an |
Shoulda also said. Thanks for hopping on this one. I was going to address the managed directories (and not much more!), so thanks for being more comprehensive. ;-) |
Can you give an explicit example of that (if you happen to have one on the web, this is a request not a demand)? I've not had that problem, but perhaps my custom code dealing with sizing meant I accidentally avoided that problem. |
I did very little use testing, only made sure that the htm was doing better. This all came about because I wanted to put a qr code in my presentation yesterday and realized that it was always getting blown up too big, no matter what width I was adding. I agree the auto resizing is annoying. I need to zoom out on the title page often, and then zoom back in when there is an image, since that is the best way to make the image smaller, when the text gets larger. |
Second attempt, using a modal template to set the No need for any sidebyside modifications, as the reveal.js conversion already handled that correctly. |
Third time's the charm I think. Using |
Much better! ;-)
|
Ah, that's much cleaner. Should be ready for squashing. |
Looking good. Thanks for working through this one. The addition of an extra While I'm at it see: #2159 |
Replaced the simple
image
template with a tweaked override of the html non-sidebyside image container. Now images in reveal.js slideshows will behave just like html images, except if they are bare images they can have a@pause
.In particular, this will respect managed directories. Closes #2155 .