Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX: Download page #1038

Closed
leoarnold opened this issue Oct 20, 2016 · 2 comments
Closed

UX: Download page #1038

leoarnold opened this issue Oct 20, 2016 · 2 comments

Comments

@leoarnold
Copy link

leoarnold commented Oct 20, 2016

Confusion: On the download page I tried to download Prism files with the Okaida theme, but the downloaded files would always provide the default theme.

Root cause: There are two independent theme selectors: one will set the theme displayed, the other the theme in the files to be downloaded.

Suggestion: Synchronize the two selectors or redesign to one selector in order to make the page more "WYSIWYG".

@LeaVerou
Copy link
Member

LeaVerou commented Oct 21, 2016

Yeah, I've often thought the current theme should be the default on the download page.
That should be relatively easy to implement, and a good first PR!

Btw, we should add a "good first PR" label for issues. I would add it but I'm not sure if there's a standard wording, and searching didn't yield any good results. Anyone knows?

@Golmote
Copy link
Contributor

Golmote commented Feb 3, 2018

@LeaVerou Here are suggestions for label names, taken from https://github.com/MunGell/awesome-for-beginners:

  • first-timers-only (it's popular, but I'm not a big fan of it, since it prevents anyone more experienced from fixing the issue, which I think is stupid)
  • good first issue, good-beginner-issue, good-for-beginner, easy-pick, first timers welcome, good-first-contribution, beginner-friendly
  • beginner, Level:Starter, exp/beginner, difficulty/newcomer (which implies, I suppose, creating other labels for other levels of estimated difficulty)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants