More variables for better code compression #1489
Conversation
Fixed namespace pollution of django
|
Variables are now assigned on a separate line. |
|
@RunDevelopment I'm sorry, that's the opposite of what I intended. I think I confused you because I commented on a line that was correct, not one to fix. My apologies for that. To be clear, I like assign the variable as well as to Sorry about that! |
|
@mAAdhaTTah |
|
@mAAdhaTTah Unrelated: Maybe we should expand the tests for |
This would be great. You should be able to add additional tests in a separate PR without conflicting with this one. |
|
This looks good to me. A little concerned about introducing a lot of conflicts merging this. There's a PR for plsql I think that will be rough to land after this. |
|
That's right, we should land #1501 before this. |
|
Using a little copy function, I compressed AsciiDoc even further. This should also be a plus in terms of maintainability. |
|
@RunDevelopment If we resolve these conflicts, I'll give this a final review and get this in. |
|
Done. |
This PR adds new temporary variables to some language definitions so the minifier can better compress the code.
Usually, this only saves about 100~200 bytes or so.
In the case of
textile, we actually save about 0.6kb or about 16% of the minified file.This also fixed the namespace pollution introduced by
django.This PR deals with syntactic changes only. If you spot a semantic change, please tell, that's a bug.