-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SQL: Quoted variables are now greedy #1510
Conversation
Got conflicts here, probs a result of the other SQL PR I just merged. |
Are there styles for |
I know any styles for |
Give that a shot if you think it's feasible. I'd definitely like to avoid introducing new tokens used in a single language, if possible. |
I did implement the merged Is it ready to merge then? |
This resolves #1509.
I added a small fix to bypass #1492.
It now (mostly) works because the quoted variables are now matched before strings. Therefore strings (of quoted variables) are always contained by the variable which leads to there match being discarded.
This little trick also reduces the greedy matching overhead because it doesn't have to rematch any patterns. Maybe we should include this trick into the docs as a best practice?