AQL: Unclosed multi-line comments are allowed #2058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RunDevelopment
approved these changes
Sep 18, 2019
|
Thank you for contributing! |
Simran-B
added a commit
to Simran-B/prism
that referenced
this pull request
Oct 14, 2019
This reverts commit f3c6ba5.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AQL does not require multi-line comments to be closed:
ArangoDB simply treats everything until the end of the query string as comment in that case. This PR adjusts Prism to highlight such comments correctly.
Note that the test for this needs to be last, as everything past it will be treated as part of this comment.