Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix attribute names with $ in their names not being picked up for jsx #2144

Merged
merged 1 commit into from
Jan 5, 2020

Conversation

ceymard
Copy link
Contributor

@ceymard ceymard commented Dec 20, 2019

  • Fixed the pattern ($-] instead of -$])
  • Ran gulp
  • Added a test case

Copy link
Member

@RunDevelopment RunDevelopment left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one thing to make Travis happy:

It seems like you have the latest npm version. We have a slight problem where npm installs different uglifyJS versions which makes the build fail. To fix this: delete the node_modules directory, discard any changes made to package-lock.json, run npm ci && npx gulp in Prism's directory.
After these steps, the changes to all the unrelated files should be gone and the build should pass.

@ceymard
Copy link
Contributor Author

ceymard commented Dec 22, 2019

Alright, I force pushed after following your instructions which in effect only shows the jsx files as being modified.

Is travis gonna run on its own ?

Copy link
Member

@RunDevelopment RunDevelopment left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, Travis ran and approved.
I'll merge your PR after we release the new version which will be in one or two weeks because of the holidays.

@RunDevelopment RunDevelopment merged commit f018cf0 into PrismJS:master Jan 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants