Tests: Added strict checks for Prism.languages.extend
#2572
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a check for the best practice for the token order in the
redef
object that I outlined here. Tests will now fail if best practices aren't followed.I tried to make the error message as descriptive as possible:
There is one exception to this check: if the redef object is the clone of another language, then the order of properties won't be checked. This is because we don't have control over the property order in this case.
One might argue that this just letting bugs slip through (I would argue that) but for now it's the easiest solution just to ignore them. They haven't caused any trouble yet.