Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flipped class added multiple times #2699

Closed
xjArea opened this issue Jan 6, 2021 · 5 comments · Fixed by #2787
Closed

flipped class added multiple times #2699

xjArea opened this issue Jan 6, 2021 · 5 comments · Fixed by #2787

Comments

@xjArea
Copy link

xjArea commented Jan 6, 2021

Information:

  • Prism version: 1.23
  • Plugins: Previewers

When tip add flipped className, it will add many times, the class name will repeat.

Here is the screenshort in Chrome :
QQ截图20210106225042_r1_c1

@mAAdhaTTah
Copy link
Member

IE10 is long since EOL'd and unsupported by Prism.

@xjArea
Copy link
Author

xjArea commented Jan 6, 2021

Prism can run on IE10, just need to add the Polyfill of Element.prototype.matches(), if has the sub plugins, prevent auto create and manual operate Prism.highlightAll(), than we can solve the problem, I've done a lot of tests using Prism on IE10, although there are some small problems, but it really can run, so please don't close this issue, I'm already fixed the BUG and passed the test on IE10... 😂😂😂

@RunDevelopment
Copy link
Member

@xjArea It's not that we are unable to support IE10. We don't want to support IE10. IE10 already EOL'd and barely has any users left today. It is not rational to focus our development efforts on a browser that close to none of our users have.

@xjArea
Copy link
Author

xjArea commented Jan 6, 2021

OK, let's forget this IE10 problem, but there is another problem with this plugin. When tip add flipped className, it will add many times, the class name will repeat. This is not the IE10 problem. Chrome and Firefox has the same problem, forgive me, I'm a lazy person and I don't want to open an new issue. Could we solve it ? When you solve this problem, maybe you can add the above code by the way, anyway, Hitchhiker ? ha-ha. 🤣

Here is the screenshort in Chrome :
QQ截图20210106225042_r1_c1

@mAAdhaTTah mAAdhaTTah reopened this Jan 6, 2021
@mAAdhaTTah mAAdhaTTah changed the title Previewers Plugin Has a Positioning BUG in IE10 flipped class added multiple times Jan 6, 2021
@mAAdhaTTah
Copy link
Member

Edited OP to capture the new issue. Will look into this. We will not be adding the IE10 code as part of that PR though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants