Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document disableWorkerMessageHandler #3088

Merged
merged 6 commits into from
Sep 23, 2021
Merged

Document disableWorkerMessageHandler #3088

merged 6 commits into from
Sep 23, 2021

Conversation

jakearchibald
Copy link
Contributor

@jakearchibald jakearchibald commented Sep 20, 2021 •
edited
Loading

We're going to use this in SVGOMG, so I figured it should be documented 😄

@github-actions
Copy link

github-actions bot commented Sep 20, 2021 •
edited
Loading

No JS Changes

Generated by 🚫 dangerJS against da3b4ce

@jakearchibald jakearchibald mentioned this pull request Sep 20, 2021
Merged
@RunDevelopment
Copy link
Member

I didn't even know we had this option. Thank you for documenting it!

Unfortunately, you documented the wrong file. prism.js is generated. Please document components/prism-core.js instead, run npm ci && npm run build, and commit all changes.

@jakearchibald
Copy link
Contributor Author

Done!

RunDevelopment
RunDevelopment requested changes Sep 23, 2021
View reviewed changes
Copy link
Member

@RunDevelopment RunDevelopment left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay @jakearchibald!

components/prism-core.js Outdated Show resolved Hide resolved
@jakearchibald
Copy link
Contributor Author

Updated

@jakearchibald
Copy link
Contributor Author

Fixed

@RunDevelopment RunDevelopment merged commit 213cf7b into PrismJS:master Sep 23, 2021
@RunDevelopment
Copy link
Member

Thank you for contributing @jakearchibald!

@jakearchibald jakearchibald deleted the patch-1 branch September 23, 2021 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RunDevelopment RunDevelopment RunDevelopment approved these changes

Assignees
No one assigned
Labels
docs enhancement needs changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jakearchibald @RunDevelopment