Added support for Stata's Ado and Mata #3383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JS File Size Changes (gzipped)A total of 4 files have changed, with a combined diff of +1.38 KB (+27.6%).
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #3294.
This PR adds both Ado and Mata. This is because Ado embeds Mata, so I needed both (and because by the time I realized that the issue requested Ado instead of Mata, I had already implemented 80% of Mata...).
Frankly, implementing Ado wasn't fun. The documentation isn't great. I wasn't able to find any Ado overview, and I am sure as hell not gonna read the 2k pages of User guide + manual. I did read parts of the both, but the info I gathered wasn't great. As such, the syntax highlighting isn't great. It's passable and an ok first try, but not good. Hopefully, someone that actually knows the language can help improve it in the future.
Also, Ado's embedded Java, Mata, and Python aren't great. Ado allows for Ado variables within embedded sections of code. These variables aren't highlighted right now, because I would need #2002 to implement that.
Stata
Mata