Add ABAP language #636
Merged
Add ABAP language #636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on Ram Manohar Tiwari (rmtiwari)'s ABAPSyntaxHighlighter.
| @@ -0,0 +1,50 @@ | |||
| Prism.languages.abap= { | |||
There was a problem hiding this comment.
May you add a space before the =?
|
Thanks for contributing! Please take a look at my comments. |
|
Thanks for the comments, I did the changes. |
| lookbehind: true | ||
| }, | ||
| 'string_operator' : { | ||
| pattern: /(\s)(&{1,2})(?=\s)/, |
There was a problem hiding this comment.
The parentheses aren't needed around &{1,2}. Also, it would be shorter written as &&?. (BTW this also apply to \*{1,2} in the operator regexp above.)
|
This looks good to me. @LeaVerou, can you take a look, too? |
|
Sorry for the delay, I'm merging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the work of @rmtiwari (https://github.com/rmtiwari/ABAPSyntaxHighlighter).
Supports: