A test for examples #2216
Merged
A test for examples #2216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RunDevelopment
commented
Feb 18, 2020
mAAdhaTTah
approved these changes
Mar 7, 2020
quentinvernot
pushed a commit
to TankerHQ/prismjs
that referenced
this pull request
Sep 11, 2020
This adds a new test to validate the structure and syntax of all examples and moves the existing example test into the mocha test suite.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes two things:
The examples checks are now their own test file, so the example tests are now part of
npm testand not the gulppremergetask. I can't remember why I made it part ofpermergein the first place. No comments in #2128 either.Added a new check to validate the example files. It's rather strict.
The main intention of strict validation is to make my life as a reviewer easier. Many people (myself included) will add example files with unescaped "<" characters and other problems.
Those problems are hard to spot for humans, so I made this test. It will also speed up the code review process because almost all people will figure out how to make the tests pass.