-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for LLVM IR #2221
Add support for LLVM IR #2221
Conversation
I will review this shortly. In the mean-time: The build doesn't pass because some of the generated files weren't updated. |
Ah thanks, I wasn't sure if they should be checked in for conflict reasons. I went and looked at some other older language additions and didn't see those files being updated at the time so I wasn't sure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for submitting this language definition @porglezomp!
I left you a few comments with questions and suggestions for certain patterns. Also, please add a boolean
pattern matching true
and false
.
LLVM IR has tons of keywords, has prefixed variables, and is relatively unstable, so it makes sense to consider everything outside of a small set of exceptions to be keywords.
Thanks for your detailed review, sorry for the delay in making those changes. |
da909d4
to
7368fd4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for picking this up again!
Just a few more things and we can merge this.
Thank you for contributing @porglezomp! |
This adds support for LLVM's assembly language. https://llvm.org/docs/LangRef.html
LLVM IR has tons of keywords, has prefixed variables, and is relatively unstable, so it makes sense to consider everything outside of a small set of exceptions to be keywords.
Fixes #2109