Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6020 avoid creating cufile.log when import monai #6106

Merged
merged 4 commits into from
Mar 7, 2023

Conversation

wyli
Copy link
Contributor

@wyli wyli commented Mar 6, 2023

Fixes #6020

Description

pip install cucim
python -c "import cucim"

may create a cufile.log file in the current working directory (please see rapidsai/cucim#514)

this PR delays the cucim imports to when the modules are really needed.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

wyli added 3 commits March 6, 2023 16:41
Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
@wyli wyli marked this pull request as ready for review March 6, 2023 17:28
Copy link
Contributor

@Nic-Ma Nic-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
@drbeh Do you have any other comments?

Thanks in advance.

@mingxin-zheng
Copy link
Contributor

This also looks good to me. cucim is not used in Auto3DSeg unless users change the default.

@wyli
Copy link
Contributor Author

wyli commented Mar 7, 2023

/build

@wyli wyli enabled auto-merge (squash) March 7, 2023 07:05
@wyli wyli merged commit b85e2c6 into Project-MONAI:dev Mar 7, 2023
@wyli wyli deleted the 6020-cufile-log branch March 7, 2023 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cufile.log file in the current directory
3 participants