Fix lazy rand affine #6774
Fix lazy rand affine #6774
Conversation
Signed-off-by: function2 <[email protected]>
|
|
|
@atbenmurray could you please have a look (I'm away still)? Thanks! |
|
Hi there @function2-llx , I'm sorry you've had a problem with this. I'll take a look at the proposed fix. |
|
Thank you for your concern, @atbenmurray. I understand that this is an open-source project and issues are part of the process. Let's continue to work together to improve this project! |
|
Please forgive the delay. I've been looking into the code this morning. I think we might want to go a little further than the current PR, but I'll make suggestions in the review once I've come to a conclusion on that. |
|
@function2-llx Ok, I had a look at a limited refactor of RandAffine and the classes that it uses, but I think it isn't possible to make tweaks without making a larger refactor. As such, I think we should go ahead with the change that you are proposing. Do you want to write some unit tests to cover the change to RandAffine? We certainly need additional tests to cover this. |
|
@atbenmurray Hi, I'd like to help, but I have to rush my conference submission recently (Due on Aug. 15th), so I'm afraid that this PR is the most I can help recently. I can help more after the submission is finished. |
|
@function2-llx Don't worry about it. It has been a very useful spot! I'll write up some additional unit tests to go with it. |
|
/build |
Fixes #6773.
Description
Call
rand_affine_grid()once before callrand_affine_grid.get_transformation_matrix(), since its documented as "Get the most recently applied transformation matrix", or the.affineattribute will not be set.Also, set
randomize=Falsehere since randomization if performed in the beginning of the function.Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.