Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add download_large_files in monai/bundle/scripts.py #6958

Merged
merged 5 commits into from
Sep 7, 2023
Merged

Add download_large_files in monai/bundle/scripts.py #6958

merged 5 commits into from
Sep 7, 2023

Conversation

KumoLiu
Copy link
Contributor

@KumoLiu KumoLiu commented Sep 7, 2023

Fixes #6362 .

Description

Add download_large_files in monai/bundle/scripts.py.
Refer to the one in https://github.com/Project-MONAI/model-zoo/blob/131b0da3f540ed13a8a1c02d8395e92a682d47cf/ci/utils.py#L93.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

wyli
wyli reviewed Sep 7, 2023
View reviewed changes
monai/bundle/scripts.py Outdated Show resolved Hide resolved
wyli
wyli reviewed Sep 7, 2023
View reviewed changes
monai/bundle/scripts.py Outdated Show resolved Hide resolved
wyli
wyli approved these changes Sep 7, 2023
View reviewed changes
Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it looks good to me.

@KumoLiu
address comments
9432f8a 
Signed-off-by: KumoLiu <[email protected]>
@wyli
Copy link
Contributor

wyli commented Sep 7, 2023

/build

@wyli wyli enabled auto-merge (squash) September 7, 2023 11:50
@wyli wyli merged commit ef7debe into Project-MONAI:dev Sep 7, 2023
26 of 32 checks passed
@KumoLiu KumoLiu deleted the download-large-files branch September 8, 2023 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wyli wyli wyli approved these changes

@ericspod ericspod Awaiting requested review from ericspod

@Nic-Ma Nic-Ma Awaiting requested review from Nic-Ma

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bundle Download Large Files
2 participants
@KumoLiu @wyli