Fix the computation of the crop region end index #7825
+5
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7824.
Description
The main impact of the PR is to change the computation of the end index for the extended box that
RandCropBoxByPosNegLabeld
uses to sample foreground centers in whenself.whole_box = True
. The problem and the fix is described in detail in the issue.The PR furthermore makes a minor change to the computation of the start index of the extended box to ensure a center chosen at the margin will fully contain the original box.
I have not run the full test suite, but I have checked that I do not break the relevant unit-test: test_rand_crop_by_pos_neg_labeld.py
Types of changes
./runtests.sh -f -u --net --coverage
../runtests.sh --quick --unittests --disttests
.make html
command in thedocs/
folder.