-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8029 update load old weights function for diffusion_model_unet.py #8031
8029 update load old weights function for diffusion_model_unet.py #8031
Conversation
Signed-off-by: Yiheng Wang <[email protected]>
Tested with this branch.
|
Hi @yiheng-wang-nv, thanks for the update, could you please test https://github.com/Project-MONAI/MONAI/blob/dev/tests/test_diffusion_model_unet.py#L581? It looks like different branches lead to different blocks, and this test case doesn't seem to be able to be imported correctly in this pr. |
Signed-off-by: Yiheng Wang <[email protected]>
…g-nv/MONAI into 8029-fix-difussion-load-error
Thanks @KumoLiu . I updated the code to support both cases |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick update, LGTM.
Co-authored-by: YunLiu <[email protected]> Signed-off-by: Yiheng Wang <[email protected]>
Hi @ericspod, could you please also help review this one? Thanks! |
/build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine to me as it's passing your tests.
…oject-MONAI#8031) Fixes Project-MONAI#8029 . ### Description A few sentences describing the changes proposed in this pull request. ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [ ] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [ ] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [ ] In-line docstrings updated. - [ ] Documentation updated, tested `make html` command in the `docs/` folder. --------- Signed-off-by: Yiheng Wang <[email protected]> Signed-off-by: Yiheng Wang <[email protected]> Co-authored-by: YunLiu <[email protected]>
Fixes #8029 .
Description
A few sentences describing the changes proposed in this pull request.
Types of changes
./runtests.sh -f -u --net --coverage
../runtests.sh --quick --unittests --disttests
.make html
command in thedocs/
folder.