-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bun runtime support #1323
Labels
Milestone
Comments
6 tasks
6 tasks
Making good progress here! |
BunDid a little testing with Bun 1.0. Got an error related to importing htmlparser 116 | async function trackResourcesForRoute(html, compilation, route) {
117 | const { context } = compilation;
118 | const root = htmlparser.parse(html, {
^
TypeError: htmlparser.parse is not a function. (In 'htmlparser.parse(html, {
script: !0,
style: !0
})', 'htmlparser.parse' is undefined)
at /Users/owenbuckley/Workspace/project-evergreen/greenwood/packages/cli/src/lib/resource-utils.js:118:15
at trackResourcesForRoute (/Users/owenbuckley/Workspace/project-evergreen/greenwood/packages/cli/src/lib/resource-utils.js:116:38)
at /Users/owenbuckley/Workspace/project-evergreen/greenwood/packages/cli/src/lifecycles/prerender.js:121:10
at /Users/owenbuckley/Workspace/project-evergreen/greenwood/packages/cli/src/lifecycles/prerender.js:107:37
at /Users/owenbuckley/Workspace/project-evergreen/greenwood/packages/plugin-renderer-puppeteer/src/puppeteer-handler.js:19:18
at /Users/owenbuckley/Workspace/project-evergreen/greenwood/packages/plugin-renderer-puppeteer/src/puppeteer-handler.js:13:23
at processTicksAndRejections (:1:2602) Made this change to the import and confirmed it worked in both Bun and Node and so was than able to succesfully build! // before
import htmlparser from 'node-html-parser';
// after
import * as htmlparser from 'node-html-parser'; However, it looks like the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Type of Change
Feature
Summary
Splitting of from #953 and based on some initial prototyping being conducted here, it seems like there is a very happy path towards basic Bun support for Greenwood.
What does that mean in practice? Effectively instead of using npm and node, levarge the equivalents in Bun
$ bun install $ bun dev # maps to `greenwood develop`
Details
Some of the main considerations to account for as part of this work
The text was updated successfully, but these errors were encountered: