Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

components are over rendering #348

Closed
1 of 5 tasks
thescientist13 opened this issue May 7, 2020 · 1 comment
Closed
1 of 5 tasks

components are over rendering #348

thescientist13 opened this issue May 7, 2020 · 1 comment
Labels
bug Something isn't working CLI question Further information is requested v0.10.0
Milestone
1.0

Comments

@thescientist13
Copy link
Member

thescientist13 commented May 7, 2020 •
edited
Loading

Type of Change

  • New Feature Request
  • Documentation / Website
  • Improvement / Suggestion
  • Bug
  • Other (please clarify below)

Summary

Observed as part of reviewing #345 (comment), but all headers and footers (regardless of GraphQL usage) are rendering a LOT on load.
excessive-component-rerendering

It should be noted that in develop / SPA mode, we get what we would probably consider the appropriate amount of renders (x2)
image

Details

Not sure why. Maybe related to some of these issues

  1. Dedupe content in JavaScript #305 - maybe if we could leverage lit-html based hydration, that might help?
  2. Route Based Code Splitting #265 - not sure if the restructuring of app-template.js fixes this?

If it's related to no, 2, then this might require some sort of documentation for a pattern users may need to follow.
@thescientist13 thescientist13 added bug Something isn't working question Further information is requested P0 Critical issue that should get addressed ASAP labels May 7, 2020
@thescientist13 thescientist13 added this to the MVP milestone May 7, 2020
@thescientist13 thescientist13 mentioned this issue May 7, 2020
Closed
5 tasks
@thescientist13 thescientist13 changed the title components are over rendering components are over rendering (in production build) May 7, 2020
@thescientist13 thescientist13 mentioned this issue Aug 6, 2020
Closed
13 tasks
@thescientist13 thescientist13 changed the title components are over rendering (in production build) components are over rendering with spa optimization setting Aug 6, 2020
@thescientist13 thescientist13 mentioned this issue Sep 22, 2020
Merged
20 tasks
@thescientist13 thescientist13 mentioned this issue Nov 8, 2020
Closed
5 tasks
@thescientist13 thescientist13 removed the P0 Critical issue that should get addressed ASAP label Nov 8, 2020
@thescientist13 thescientist13 changed the title components are over rendering with spa optimization setting components are over rendering Apr 4, 2021
@thescientist13
Copy link
Member Author

no longer an issue since in v0.10.0 (likely because we use HTML first, not JavaScript)

@thescientist13 thescientist13 mentioned this issue Apr 4, 2021
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working CLI question Further information is requested v0.10.0
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
1 participant
@thescientist13