Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

html minification #357

Open
1 of 5 tasks
thescientist13 opened this issue Jun 4, 2020 · 1 comment
Open
1 of 5 tasks

html minification #357

thescientist13 opened this issue Jun 4, 2020 · 1 comment
Labels
CLI feature New feature or request
Milestone
1.0

Comments

@thescientist13
Copy link
Member

thescientist13 commented Jun 4, 2020 •
edited
Loading

Type of Change

  • New Feature Request
  • Documentation / Website
  • Improvement / Suggestion
  • Bug
  • Other (please clarify below)

Summary

To help save even more bytes by reducing overall index.html size, we should minify all HTML. Related to the conversation here

Also, anywhere we are using \n inside (tagged) template literals, we should remove them since template literals already preserve line breaks, so adding the \n just adds more space.

Details

Because all the HTML is created by serializing with puppeteer, we wouldn't really be able to do it with webpack, and so would have it do it in the serialize lifecycle, I believe.

~~Was also thinking validating the HTML might be good but as since this is coming from puppeteer, I think that would / could be assumed...~~~ - we do this now via #631 and subsequent PRs
@thescientist13 thescientist13 added the enhancement Improve something existing (e.g. no docs, new APIs, etc) label Jun 4, 2020
@thescientist13 thescientist13 added this to the VP milestone Jun 4, 2020
@thescientist13 thescientist13 changed the title html minification html minification (and validation?) Jun 4, 2020
This was referenced Aug 5, 2020
Merged
Closed
@thescientist13 thescientist13 mentioned this issue Sep 22, 2020
Closed
53 tasks
@thescientist13 thescientist13 removed this from the VP milestone Oct 15, 2020
@thescientist13 thescientist13 added this to the 1.0 milestone Apr 4, 2021
@thescientist13 thescientist13 added feature New feature or request and removed enhancement Improve something existing (e.g. no docs, new APIs, etc) labels Feb 9, 2022
@thescientist13 thescientist13 added enhancement Improve something existing (e.g. no docs, new APIs, etc) and removed feature New feature or request labels Feb 27, 2022
@thescientist13 thescientist13 added feature New feature or request and removed enhancement Improve something existing (e.g. no docs, new APIs, etc) labels Mar 15, 2022
@thescientist13
Copy link
Member Author

Not sure if this is something we need to do? Seems like it would be better handled by the CDN or hosting provider. May end up closing this.

@thescientist13 thescientist13 changed the title html minification (and validation?) html minification Nov 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CLI feature New feature or request
Projects
[Greenwood] Phase 11 - Burndown to 1.0
Status: 📋 Backlog
Milestone
1.0
Development

No branches or pull requests
1 participant
@thescientist13