You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The current implementation for server rendering routes requires that we run the final HTML on the fly through Rollup at minimum because bundled JS / CSS files will get content hashed, which means that the paths in the templates, e.g.
At its simplest, we could easily add a check to Rollup to check for the existence of a bundled file first and thus avoid the whole emitFile pass, and just rely on HTML updating logic.
The main reason a heavy handed approach was taken because in theory users could additional script tags on the fly in their getTemplate function that may never get statically pre-bundled, so this makes sure that all cases are covered, but perhaps this may not be needed? But maybe there's an even better way to do this?
The text was updated successfully, but these errors were encountered:
Type of Change
Summary
The current implementation for server rendering routes requires that we run the final HTML on the fly through Rollup at minimum because bundled JS / CSS files will get content hashed, which means that the paths in the templates, e.g.
Get properly turned into something like
Details
At its simplest, we could easily add a check to Rollup to check for the existence of a bundled file first and thus avoid the whole
emitFile
pass, and just rely on HTML updating logic.The text was updated successfully, but these errors were encountered: