Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSR index pages are generating the wrong route and not loading correctly in development #984

Closed
1 of 5 tasks
thescientist13 opened this issue Oct 16, 2022 · 0 comments · Fixed by #985
Closed
1 of 5 tasks
Assignees
Labels
bug Something isn't working CLI P0 Critical issue that should get addressed ASAP SSR v0.26.1
Milestone

Comments

@thescientist13
Copy link
Member

Type of Change

  • New Feature Request
  • Documentation / Website
  • Improvement / Suggestion
  • Bug
  • Other (please clarify below)

Summary

It looks like index.js page routes (specifically) are not resolving to the right route.

src/
  pages/
    index.js

Will yield a broken page

Screen Shot 2022-10-16 at 6 30 16 PM

Details

It looks like we were not applying the correct "index" resolution logic to dynamic pages like we are static pages. Logging the graph, we can see the route is coming out as /index instead of just /

[{
  data: {},
  filename: 'index.js',
  id: 'index',
  label: 'Index',
  imports: [],
  outputPath: '/indexindex.html',
  path: '/index',
  route: '/index',
  template: 'page',
  title: null,
  isSSR: true
}]
@thescientist13 thescientist13 added bug Something isn't working P0 Critical issue that should get addressed ASAP CLI SSR labels Oct 16, 2022
@thescientist13 thescientist13 added this to the 1.0 milestone Oct 16, 2022
@thescientist13 thescientist13 self-assigned this Oct 16, 2022
@thescientist13 thescientist13 changed the title SSR index pages are generating the wrong route and not loading correctly SSR index pages are generating the wrong route and not loading correctly in development Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CLI P0 Critical issue that should get addressed ASAP SSR v0.26.1
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant