Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use SVGs for all logos and icons #71

Closed
thescientist13 opened this issue Jul 7, 2024 · 0 comments · Fixed by #86
Closed

use SVGs for all logos and icons #71

thescientist13 opened this issue Jul 7, 2024 · 0 comments · Fixed by #86
Assignees
@Auhseh
Labels
enhancement New feature or request good first issue Good for newcomers sponsorship:eligible
Milestone
Website Redesign ...

Comments

@thescientist13
Copy link
Member

thescientist13 commented Jul 7, 2024 •
edited
Loading

Summary

A couple of our image assets that could probably be SVGs are not, and instead are PNGs.

Would like to at least acquire the following as SVGs

  1. node
  2. netlify
  3. vercel (seems to just be an SVG "wrapper" around a base64 encoded image)
  4. WCC (seems to just be an SVG "wrapper" around a base64 encoded image - @thescientist13 to tracking down)

Details

Will then want to refactor platform component to use inline <svg> instead of <img>, which should then address this Lighthouse item(s) all related to images
Screenshot 2024-08-18 at 2 56 26 PM
Screenshot 2024-08-18 at 2 59 44 PM
Screenshot 2024-08-18 at 2 59 39 PM
@thescientist13 thescientist13 added the good first issue Good for newcomers label Aug 18, 2024
@thescientist13 thescientist13 changed the title acquire SVGs for all assets acquire and use SVGs for all logos and icons Aug 18, 2024
@thescientist13 thescientist13 changed the title acquire and use SVGs for all logos and icons use SVGs for all logos and icons Aug 18, 2024
@thescientist13 thescientist13 mentioned this issue Aug 18, 2024
Merged
36 tasks
@Auhseh Auhseh self-assigned this Sep 3, 2024
@Auhseh Auhseh linked a pull request Sep 3, 2024 that will close this issue
enhancement/issue 71 acquire svgs for all assets #86
Merged
4 tasks
@thescientist13 thescientist13 mentioned this issue Sep 5, 2024
Merged
4 tasks
@thescientist13 thescientist13 moved this from 🏗 In progress to 👀 In review in [Greenwood] Website Redesign and Relaunch Sep 9, 2024
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in [Greenwood] Website Redesign and Relaunch Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Auhseh Auhseh

Labels
enhancement New feature or request good first issue Good for newcomers sponsorship:eligible
Projects
[Greenwood] Website Redesign and Relaunch
Status: ✅ Done
Milestone
Website Redesign and Relaunch
Development

Successfully merging a pull request may close this issue.

enhancement/issue 71 acquire svgs for all assets ProjectEvergreen/www.greenwoodjs.dev
2 participants
@thescientist13 @Auhseh