Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

leverage content as data for the header component navigation content #88

Closed
thescientist13 opened this issue Sep 5, 2024 · 0 comments · Fixed by #122
Closed

leverage content as data for the header component navigation content #88

thescientist13 opened this issue Sep 5, 2024 · 0 comments · Fixed by #122
Assignees
Labels
enhancement New feature or request invalid This doesn't seem right

Comments

@thescientist13
Copy link
Member

thescientist13 commented Sep 5, 2024

Summary

Once #84 lands, the initial seeds for content as data will be available (via patch package patches), which means we can now leverage this in the header to generate the navigation menus.

With this, we should also be able to add an "active" class to each navigation item to give it an underline when it is the active page.

Details

Basically we would want to add collection and order to the frontmatter of each of the relevant pages, once they have been done / merged

  1. Docs Page #31
  2. Guides Page #33
  3. Blog Landing Page #34
----
collection: nav
order: 1
----

You can see an example here -

const nav = JSON.parse(this.getAttribute("nav") || "[]").sort((a, b) =>


We might also want to make it so that the active link gets a style for it, at minumum an underline would be nice, especially when you're on the Docs or Guides pages, since they have similar layouts so having that visual breadcrumb would be nice.
Screenshot 2024-10-15 at 8 07 11 PM

@thescientist13 thescientist13 added the enhancement New feature or request label Sep 5, 2024
@thescientist13 thescientist13 changed the title leverage content as data for the header component navigation leverage content as data for the header component navigation content Sep 5, 2024
@thescientist13 thescientist13 added the good first issue Good for newcomers label Sep 5, 2024
@thescientist13 thescientist13 moved this from 🔖 Ready to 📋 Backlog in [Greenwood] Website Redesign and Relaunch Sep 8, 2024
@thescientist13 thescientist13 added invalid This doesn't seem right and removed good first issue Good for newcomers labels Sep 8, 2024
@thescientist13 thescientist13 self-assigned this Oct 28, 2024
@thescientist13 thescientist13 moved this from 📋 Backlog to 🏗 In progress in [Greenwood] Website Redesign and Relaunch Oct 28, 2024
@thescientist13 thescientist13 moved this from 🏗 In progress to 👀 In review in [Greenwood] Website Redesign and Relaunch Oct 28, 2024
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in [Greenwood] Website Redesign and Relaunch Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request invalid This doesn't seem right
Projects
Development

Successfully merging a pull request may close this issue.

1 participant