Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mirador (for React reuse) distribution should not bundle React #2003

Closed
christopher-johnson opened this issue Mar 1, 2019 · 1 comment
Closed

Comments

@christopher-johnson
Copy link
Contributor

FYI: The react-i18next update caused this error https://reactjs.org/warnings/invalid-hook-call-warning.html downstream.

I have understood that React components libraries should not bundle their own React (which may cause the third item "You might have more than one copy of React in the same app" in the implementation).

As a bundling and distribution issue, this can be fixed with webpack.

@mejackreed
Copy link
Collaborator

We recognize this as a use case and did some POC work here on this: https://github.com/ProjectMirador/research-and-demos/pull/89/files

@cbeer cbeer closed this as completed Jun 17, 2021
@cbeer cbeer closed this as not planned Won't fix, can't repro, duplicate, stale Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants