-
Notifications
You must be signed in to change notification settings - Fork 172
Run example AdvancedEffects for a while (9~66 seconds) may encountered an EXC_BAD_ACCESS exception. #38
Comments
what version of gl-react-native ? |
1.3.0 |
i'm suspecting a race condition with some gl calls that is not running in the gl thread. I've fixed some of these in e43409f but there might remain bugs. Need to review some code if you confirm this still happens after this commit (1.3.0 should have this commit) |
mmh ok. I need to try to reproduce then. thanks for the report |
It won't happen if I comment out "Vignette" and "Slideshow" components in 'src/index.js' render method. |
Slideshow might the cause, it swap over a bunch of transitions. Maybe increasing the transition speed can trigger the error more easily? (like |
Well the Vignette can also trigger the exception. |
do you have this exclusively on the phone or also on the simulator? |
I've just tested on the phone. |
sorry there is something I forgot to ask you. Do you have any other logs in the console before this happens? You might have an error like I suspect #41 will fix it. |
No, I have not seen an error like that. |
Ok thanks. I'll work on this ASAP. This is highest priority on gl-react-native issues. |
This should be fixed in https://github.com/ProjectSeptemberInc/gl-react-native/releases/tag/v2.17.0 Feel free to reopen if it's not |
That happened again with the new version (2.17.0) [Screenshot] https://dl.dropboxusercontent.com/u/7632930/Screenshots/Screenshot_2015-12-20_21.26.25.png |
weird. Can you try to replace https://github.com/ProjectSeptemberInc/gl-react-native/blob/master/Examples/AdvancedEffects/src/index.js#L23
by
? thanks |
Got the same crash with this change. |
I can repro on iPhone 6, i'll investigate on this |
I've released a v2.17.2, |
released a v2.17.3 which probably fixes the second issue :) |
I've just run AdvancedEffects several times in simulator. The crash did not appear again. |
cool! thanks for your help on testing this issue :) |
Running on the real device (iPhone6p on iOS 9.1) with '--dev' flag 'false'.
I've not seen that happened when set '--dev' to 'true'.
The text was updated successfully, but these errors were encountered: