Skip to content
This repository has been archived by the owner on Jan 1, 2020. It is now read-only.

Run example AdvancedEffects for a while (9~66 seconds) may encountered an EXC_BAD_ACCESS exception. #38

Closed
jacobbubu opened this issue Dec 3, 2015 · 22 comments

Comments

@jacobbubu
Copy link

Running on the real device (iPhone6p on iOS 9.1) with '--dev' flag 'false'.

bad-access

I've not seen that happened when set '--dev' to 'true'.

@gre
Copy link
Owner

gre commented Dec 3, 2015

what version of gl-react-native ?

@jacobbubu
Copy link
Author

1.3.0

@gre
Copy link
Owner

gre commented Dec 3, 2015

i'm suspecting a race condition with some gl calls that is not running in the gl thread. I've fixed some of these in e43409f but there might remain bugs. Need to review some code if you confirm this still happens after this commit (1.3.0 should have this commit)

@gre
Copy link
Owner

gre commented Dec 3, 2015

mmh ok. I need to try to reproduce then. thanks for the report

@jacobbubu
Copy link
Author

It won't happen if I comment out "Vignette" and "Slideshow" components in 'src/index.js' render method.

@gre
Copy link
Owner

gre commented Dec 3, 2015

Slideshow might the cause, it swap over a bunch of transitions. Maybe increasing the transition speed can trigger the error more easily? (like pauseDuration={0} transitionDuration={0.1} )

@jacobbubu
Copy link
Author

Well the Vignette can also trigger the exception.

@gre
Copy link
Owner

gre commented Dec 3, 2015

do you have this exclusively on the phone or also on the simulator?

@jacobbubu
Copy link
Author

I've just tested on the phone.

@jacobbubu
Copy link
Author

Just tested on the simulator. The exception has also been thrown from the line 391 in GLCanvas.m.

bad2

@gre
Copy link
Owner

gre commented Dec 15, 2015

sorry there is something I forgot to ask you.

Do you have any other logs in the console before this happens?

You might have an error like [warn][tid:main][GLShader.m:78] Shader '<name of the shader>': not a program!

I suspect #41 will fix it.

@jacobbubu
Copy link
Author

@gre
Copy link
Owner

gre commented Dec 15, 2015

Ok thanks. I'll work on this ASAP. This is highest priority on gl-react-native issues.

@gre gre modified the milestone: 0.17 Dec 19, 2015
@gre gre closed this as completed in #48 Dec 20, 2015
@gre
Copy link
Owner

gre commented Dec 20, 2015

This should be fixed in https://github.com/ProjectSeptemberInc/gl-react-native/releases/tag/v2.17.0

Feel free to reopen if it's not

@jacobbubu
Copy link
Author

That happened again with the new version (2.17.0)

[Screenshot] https://dl.dropboxusercontent.com/u/7632930/Screenshots/Screenshot_2015-12-20_21.26.25.png

@gre gre reopened this Dec 20, 2015
@gre
Copy link
Owner

gre commented Dec 20, 2015

weird.

Can you try to replace https://github.com/ProjectSeptemberInc/gl-react-native/blob/master/Examples/AdvancedEffects/src/index.js#L23

      embeddedImage: resolveAssetSource(require("./Image.jpg")),

by

      embeddedImage: "http://i.imgur.com/2VP5osy.jpg",

?

thanks

@jacobbubu
Copy link
Author

Got the same crash with this change.

@gre gre removed this from the 0.17 milestone Dec 21, 2015
@gre
Copy link
Owner

gre commented Dec 23, 2015

I can repro on iPhone 6, i'll investigate on this

@gre gre closed this as completed in 38d4516 Dec 28, 2015
@gre
Copy link
Owner

gre commented Dec 28, 2015

I've released a v2.17.2,
it should fix the crash around gl_drawArrays (the one you reported with this screenshot), however there is still the initial crash you reported (the assembly one around AGXResourceDescriptor::AGXResourceDescriptor), I have trouble tracing this one...

@gre gre reopened this Dec 28, 2015
@gre
Copy link
Owner

gre commented Dec 28, 2015

released a v2.17.3 which probably fixes the second issue :)

@jacobbubu
Copy link
Author

I've just run AdvancedEffects several times in simulator. The crash did not appear again.

@gre
Copy link
Owner

gre commented Dec 29, 2015

cool! thanks for your help on testing this issue :)
再见 :)

@gre gre closed this as completed Dec 29, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants