Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Maps API Test the new Camera control on your maps before the default changes in version 3.60 #3620

Closed
jonfroehlich opened this issue Aug 20, 2024 · 6 comments · Fixed by #3791
Assignees

Comments

@jonfroehlich
Copy link
Member

Received the following email:

We are changing the Google Maps JavaScript API controls to reduce the space they occupy on maps by default and to improve the accessibility of panning the map.

We’re reaching out to you because we have observed one or more of the following criteria:

  • Your end-users use the Zoom buttons significantly more than the average.
  • One or more of your maps explicitly disables the Zoom control.
  • One or more of your maps have customized controls.
image image
@misaugstad
Copy link
Member

Wow, you just beat me to it, I had just taken that screenshot myself!

@misaugstad
Copy link
Member

@aslassi777 I think that this should be your next task! I think that this is just for the map, not for Street View. And the only map that we use from Google is the mini map on the Explore page. What I'm hoping to get from you is:

  1. Make any changes necessary so that nothing breaks when support for the old controls is removed in February (it sounds like this can be tested by running the beta channel)
  2. Switch us from using the quarterly channel to the weekly channel! I was being conservative before, but we don't really need to be on the quarterly channel.
  3. Remove references to the old controls that are now deprecated.
  4. Make sure that these changes work with our website now on the weekly channel!
  5. Fully document everything and write it up either here or in the PR such that I feel confident that you've done your due diligence and I don't feel like I should be looking over the API myself as well :)

@aslassi777
Copy link
Collaborator

@misaugstad Sounds good! I'll get this started over the weekend and will reach out if I have any questions

@aslassi777
Copy link
Collaborator

aslassi777 commented Sep 28, 2024

@misaugstad Just to make sure, after looking through the codebase, I've reached the file main.scala.html. This is where the Google API link seems to be, and like you mentioned, I see that it's at quarterly. This is the correct line to be changing, correct? I've already changed it to beta and played around with it (seemed to not affect anything with the maps in the Walla-Walla explore missions but I only used it for a few minutes, will test it out more in depth later), but just want to make sure.

<script type="text/javascript"
    src="https://maps.googleapis.com/maps/api/js?v=quarterly&key=@Play.configuration.getString("google-maps-api-key").get&language=@lang.code&callback=Function.prototype">
</script>

@misaugstad
Copy link
Member

@aslassi777 yes, correct!

@aslassi777
Copy link
Collaborator

aslassi777 commented Sep 29, 2024

@misaugstad checked more in depth today. After doing about 2 missions with the version set to beta, I am not seeing anything breaking or any major changes we should be accommodating for. The small google side map next to the street view works exactly how it does on the main website as it does on my localhost, at least for now. I did notice that on the website:

We recommend, in early November, you test your application using v=3.58.

So maybe can check back in on this in November, but for now, no breaking changes. I'm also going to push one change, which is to switch from the quarterly to weekly channel as you had mentioned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants