Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Random number distributions #2

Open
tmbb opened this issue Jun 13, 2024 · 2 comments
Open

Random number distributions #2

tmbb opened this issue Jun 13, 2024 · 2 comments

Comments

@tmbb
Copy link

tmbb commented Jun 13, 2024

Before I change my PR for the random number distributions, I'd like to discuss what the API should be.

The API I've written follows the GSL API very closely, but maybe I should implement the traits in the rand crate instead... That way maybe I could drop the dependency on ndarray and instead make it more flexible so that the users would be able to dump the random values into whatever "containers" they feel like (?).

@PvdBerg1998
Copy link
Owner

As I also commented on your PR: I think using the rand ecosystem makes a lot of sense. I have the feeling that there might be a major overlap between the existing native Rust rand ecosystem and the functions of the GSL, is that true? Apologies, I don't have time to check this myself at this moment.

@tmbb
Copy link
Author

tmbb commented Jun 13, 2024

I have the feeling that there might be a major overlap between the existing native Rust rand ecosystem and the functions of the GSL, is that true?

Honestly, I don't know. The thing is that all the GSL functions are meticulously documented and referenced, and I'd feel more comfortable citing GSL in a scientific paper than a random (pun intended) crate in the rand ecosystem...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants