Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Black incompatibility #1388

Closed
kunalb opened this issue Aug 18, 2020 · 2 comments
Closed

Black incompatibility #1388

kunalb opened this issue Aug 18, 2020 · 2 comments

Comments

@kunalb
Copy link

kunalb commented Aug 18, 2020

Creating a new issue based on the comments on #694

-from .trace import (
-    DurationTraceEvent,
-    FlowBindingPoint,
-    FlowTraceEvent,
-    Phase,
-    Trace,
-)
+from .trace import (DurationTraceEvent, FlowBindingPoint, FlowTraceEvent,
+                    Phase, Trace)

isort keeps moving the imports to two lines, and black then breaks them apart again.

My pyproject.toml (I've also tried without the line lengths, only keeping the profile):

[tool.black]
line-length = 79

[tool.isort]
profile = "black"
line_length = 79

In case it helps, the actual code is at https://github.com/kunalb/panopticon/blob/master/panopticon/tracer.py#L13 .

Thanks!

@kunalb
Copy link
Author

kunalb commented Aug 18, 2020

Er, I just realized I was on isort 4.x because of pylint, goes away with the latest version. Sorry about that!

@kunalb kunalb closed this as completed Aug 18, 2020
@timothycrosley
Copy link
Member

No worries! Glad to hear 5.0.0 resolved it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants