Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot figure out how to use --config to override a value from the pyproject.toml #2072

Open
1 of 2 tasks
jleibs opened this issue May 6, 2024 · 2 comments
Open
1 of 2 tasks

Comments

@jleibs
Copy link

jleibs commented May 6, 2024

Bug Description

Because of some aspects of how sources work in our dev build, I wanted to do something along the lines of the following:

maturin develop --config 'tool.maturin.python-source="rerun_sdk"' --manifest-path rerun_py/Cargo.toml

There's a config parser that's validating that it's proper dotted key=val notation, but none of the values I put there seem to make a difference.

Your maturin version (maturin --version)

1.5.1

Your Python version (python -V)

3.11.8

Your pip version (pip -V)

23.2.1

What bindings you're using

pyo3

Does cargo build work?

  • Yes, it works

If on windows, have you checked that you aren't accidentally using unix path (those with the forward slash /)?

  • Yes

Steps to Reproduce

Try building a package and overriding python-source.

@jleibs jleibs added the bug Something isn't working label May 6, 2024
@jleibs
Copy link
Author

jleibs commented May 6, 2024

I don't specifically need --config to work, but more generally I want to be able to override a few things to have different values during a dev build, and was hoping this might be an answer.

@messense
Copy link
Member

messense commented May 7, 2024

--config is a cargo specific option so it won't work for overridding values in pyproject.toml.

There are currently no option in CLI to override [tool.maturin] section in pyproject.toml.

@messense messense removed the bug Something isn't working label May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants