Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation mentioned closed issue #2464

Closed
savente93 opened this issue Jun 21, 2022 · 2 comments
Closed

Documentation mentioned closed issue #2464

savente93 opened this issue Jun 21, 2022 · 2 comments

Comments

@savente93
Copy link
Contributor

savente93 commented Jun 21, 2022

In the documentation page Organizing your module registration code it still says that

Unfortunately, though, some of the macros like wrap_pyfunction! do not yet work when used on code defined in other modules (#1709).

I checked and #1709 has since been closed and a fix seems to have been merged. Does this mean that this problem is now fixed? If so, it would be good to remove the relevant work around. If so, perhaps it's a good idea to link to the next blocking issue. I'd be happy to help, but I'm not very familiar with PyO3 yet so I fear I won't be very effective. I'm happy to spend some time on it, if someone is willing to mentor me a bit though. Thanks for all the hard work folks!

@mejrs
Copy link
Member

mejrs commented Jun 21, 2022

Yeah that part can just be deleted :) A PR would be much appreciated.

@savente93
Copy link
Contributor Author

Waiting for review :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants