Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy up GIL_COUNT access with "RestoreGuard" #2969

Closed
davidhewitt opened this issue Feb 21, 2023 · 0 comments · Fixed by #2974
Closed

Tidy up GIL_COUNT access with "RestoreGuard" #2969

davidhewitt opened this issue Feb 21, 2023 · 0 comments · Fixed by #2974

Comments

@davidhewitt
Copy link
Member

          I wonder whether we should package up `RestoreGuard` in `mod gil` to centralize the usage of `Save/RestoreThread`, accessing `GIL_COUNT` and calling `update_counts` in that module. (I suspect that having this in separate modules, i.e. making `GIL_COUNT` a `pub(crate)` item, might have been the root cause of this slipping in.)

Originally posted by @adamreichold in #2952 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant