Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming particle directions #104

Open
AntonReinhard opened this issue May 3, 2024 · 1 comment
Open

Renaming particle directions #104

AntonReinhard opened this issue May 3, 2024 · 1 comment
Labels
05 - Enhancement Improvements of existing code

Comments

@AntonReinhard
Copy link
Member

We have the type ParticleDirection with subtypes Incoming and Outgoing. This makes sense for the view outside of a process, where the particles either "go into" or "come out of" the process. However, I also like to use these directional types "inside" the calculations of Feynman diagrams, where there is no set outside or inside, so the names become arbitrary.

Maybe it would make sense to rename these to a ParticleSign instead, and have a Positive and Negative or similar. It then becomes somewhat intuitive inside a diagram, especially with the conservation of momenta.

I'm not entirely sure about this though since the names may be more confusing for someone coming from outside the project and only caring about the process-level view. Maybe we could just add aliases for Incoming -> Positive and Outgoing -> Negative or the other way around?

@AntonReinhard AntonReinhard added the 05 - Enhancement Improvements of existing code label May 3, 2024
@AntonReinhard
Copy link
Member Author

I just noticed this issue should probably go into QEDbase since that is where the particle directions are defined. We can discuss here first anyways I think.

@AntonReinhard AntonReinhard transferred this issue from QEDjl-project/QEDprocesses.jl Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
05 - Enhancement Improvements of existing code
Projects
None yet
Development

No branches or pull requests

1 participant