Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove AbstractOutPhaseSpacePoint #149

Open
AntonReinhard opened this issue Jan 21, 2025 · 0 comments
Open

Remove AbstractOutPhaseSpacePoint #149

AntonReinhard opened this issue Jan 21, 2025 · 0 comments
Labels
09 - Maintenance Related to maintenance, housekeeping, repo-config

Comments

@AntonReinhard
Copy link
Member

As discussed, the AbstractOutPhaseSpacePoint does not really serve any purpose and should therefore be removed.
However, I noticed that this makes the AbstractInPhaseSpacePoint equivalent to the normal AbstractPhaseSpacePoint because both would now require the incoming phase space to be non-empty. I would therefore propose to do the following:

  • Allow an AbstractPhaseSpacePoint to have an empty out phase space, but don't allow an empty in phase space.
  • Keep AbstractInPhaseSpacePoint as is, i.e., require the in phase space to be non-empty (which is now only an alias to AbstractPhaseSpacePoint since it also requires that). I think it would still be nice to have an explicit alias even though it's functionally the same.
  • Remove AbstractOutPhaseSpacePoint.
  • Add an AbstractFullPhaseSpacePoint (or something similar) that requires the incoming and outgoing phase space to be defined.
@szabo137 szabo137 added question Further information is requested 09 - Maintenance Related to maintenance, housekeeping, repo-config and removed question Further information is requested labels Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
09 - Maintenance Related to maintenance, housekeeping, repo-config
Projects
None yet
Development

No branches or pull requests

2 participants