Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize process, model, phase_space_definition #97

Open
szabo137 opened this issue Jul 9, 2024 · 0 comments
Open

Generalize process, model, phase_space_definition #97

szabo137 opened this issue Jul 9, 2024 · 0 comments

Comments

@szabo137
Copy link
Member

szabo137 commented Jul 9, 2024

Currently, there are three functions process, model, and phase_space_definition, which are interface functions for phase space points. However, the concept is more general, because there are other entities associated with scattering processes, computational models, and phase space definitions. For instance, certain samplers of QEDevents are also associated with these properties. Therefore, I propose to move these functions to a more general place in the code, maybe near the associated return type. Furthermore, I suggest to update the docstrings to reflect the more general usage of these functions.

Note: this change will not be breaking, because these are just exported symbols anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant