Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misleading implementation of 'dot' #21

Open
szabo137 opened this issue Sep 1, 2023 · 0 comments
Open

Misleading implementation of 'dot' #21

szabo137 opened this issue Sep 1, 2023 · 0 comments
Labels
05 - Enhancement Improvements of existing code good first issue Good for newcomers

Comments

@szabo137
Copy link
Member

szabo137 commented Sep 1, 2023

The function

dot(::AbstractLorentzVector,::AbstractLorentzVector)

implemented here seems misleading.

First, there is a function LinearAlgebra.dot that has similar behavior but QEDbase.dot is not added to the methods of the former.
Second, it seems misleading, that QEDbase.dot redirects directly to QEDbase.mdot, which is the Minkowski inner product.

In conclusion, I suggest removing the QEDbase.dot and sticking with QEDbase.mdot to underline the difference between Minkowski and Euclidian inner product.

However, the implementation of QEDbase.* seems valuable, and clear and should stay. Maybe it would be more explicit to add this implementation directly to Base.* instead of using import Base: *.

@szabo137 szabo137 added good first issue Good for newcomers 05 - Enhancement Improvements of existing code labels Sep 12, 2023
@szabo137 szabo137 transferred this issue from QEDjl-project/QEDbase.jl Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
05 - Enhancement Improvements of existing code good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant