You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
First, there is a function LinearAlgebra.dot that has similar behavior but QEDbase.dot is not added to the methods of the former.
Second, it seems misleading, that QEDbase.dot redirects directly to QEDbase.mdot, which is the Minkowski inner product.
In conclusion, I suggest removing the QEDbase.dot and sticking with QEDbase.mdot to underline the difference between Minkowski and Euclidian inner product.
However, the implementation of QEDbase.* seems valuable, and clear and should stay. Maybe it would be more explicit to add this implementation directly to Base.* instead of using import Base: *.
The text was updated successfully, but these errors were encountered:
The function
implemented here seems misleading.
First, there is a function
LinearAlgebra.dot
that has similar behavior butQEDbase.dot
is not added to the methods of the former.Second, it seems misleading, that
QEDbase.dot
redirects directly toQEDbase.mdot
, which is the Minkowski inner product.In conclusion, I suggest removing the
QEDbase.dot
and sticking withQEDbase.mdot
to underline the difference between Minkowski and Euclidian inner product.However, the implementation of
QEDbase.*
seems valuable, and clear and should stay. Maybe it would be more explicit to add this implementation directly toBase.*
instead of usingimport Base: *
.The text was updated successfully, but these errors were encountered: