Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop PkgDependency dependency #33

Closed
AntonReinhard opened this issue May 6, 2024 · 3 comments
Closed

Drop PkgDependency dependency #33

AntonReinhard opened this issue May 6, 2024 · 3 comments
Labels
05 - Enhancement Improvements of existing code

Comments

@AntonReinhard
Copy link
Member

We should probably drop PkgDependency from our dependencies or request at their package to make some functionality available which is intended for automated use.

Original from PR comment here: #31 (comment)
@AntonReinhard AntonReinhard added the 05 - Enhancement Improvements of existing code label May 6, 2024
@SimeonEhrig
Copy link
Member

PkgDependency is only part of the CI tool and if we get rid of, we need to maintain the dependency graph of the QED.jl project by hand.

@AntonReinhard
Copy link
Member Author

No, I don't mean to do it manually, I meant to implement the little functionality we actually need from it ourselves so we're safe from random changes in their repository breaking our CI, as happened with their v0.5.0. We could basically just copy their current builddict() function.

@SimeonEhrig SimeonEhrig mentioned this issue Jul 9, 2024
Closed
@SimeonEhrig
Copy link
Member

Done in IntegrationTests.jl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
05 - Enhancement Improvements of existing code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SimeonEhrig @AntonReinhard