Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

petrajectories drops the continue_status case #444

Open
Krastanov opened this issue Dec 3, 2024 · 0 comments
Open

petrajectories drops the continue_status case #444

Krastanov opened this issue Dec 3, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@Krastanov
Copy link
Member

We should probably fix this

function petrajectory_keep(state, circuit; branch_weight=1.0, current_order=0, max_order=1) # TODO a lot of repetition with petrajectory - dry out
A = Accumulator{Tuple{typeof(state),CircuitStatus},typeof(branch_weight)}
if size(circuit)[1] == 0
return A()
end

We probably want the accumulator to include

key: (state, continue_status)
value: branch_weight

I think for accumulators we need the inc! function to add that weight.

Not quite sure what is the good solution for the keepstate=False case

@IsaacP1234

@Krastanov Krastanov added the bug Something isn't working label Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant