Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up dependencies #470

Closed
renkun-ken opened this issue Aug 13, 2021 · 5 comments · Fixed by #471
Closed

Clean up dependencies #470

renkun-ken opened this issue Aug 13, 2021 · 5 comments · Fixed by #471

Comments

@renkun-ken
Copy link
Member

renkun-ken commented Aug 13, 2021

Inspired by #469, it is likely that could eliminate those dependencies if we only rely on a tiny proportion of the functions provided in the package, or if they are easily replaceable.

For example, I could not find any usage of desc (search desc::) but we still import it?

@renkun-ken
Copy link
Member Author

renkun-ken commented Aug 13, 2021

I go through the imported packages, looks like everything is fine except that desc is not used at all.

@renkun-ken
Copy link
Member Author

Also, I'd like to move roxygen2 from Imports to Suggests like rmarkdown since

  1. It has quite heavy dependencies.
  2. We only use roxygen2:::parse_text().
  3. It is optional and more useful for package developers who are very likely to have installed roxygen2.

@renkun-ken
Copy link
Member Author

But it looks like most (if not all) dependencies of roxygen2 also appear in the dependencies of styler and lintr, then removing roxygen2 might not help reduce the installation size and time at all.

@randy3k
Copy link
Member

randy3k commented Aug 13, 2021

But it looks like most (if not all) dependencies of roxygen2 also appear in the dependencies of styler and lintr, then removing roxygen2 might not help reduce the installation size and time at all.

Then I guess we could keep it.

@lorenzwalthert
Copy link
Contributor

FWIW: Also note that {lintr} undergoes a dependency cut: r-lib/lintr#861

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants