-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Won't launch browser even when specified #10
Comments
Thanks for reporting! We've never tested that functionality before, the only Linux support we vouch for is python, described at https://github.com/RLBot/RLBot/wiki/Operating-System-Support, and rust unofficially. I'll consider this a feature request 👍 |
Hey Tarehart, |
Thanks! Linux support was set up by @kipje13, he did a great job :) This is the code you're probably thinking of: https://github.com/RLBot/RLBot/blob/master/src/main/python/rlbot/botmanager/scratch_manager.py#L118 There could easily be some stuff in there that's not properly cross-platform. You'll also see that Chrome is a requirement when using the spawn_browser setting. |
OK, great news! After doing some testing, I discovered that the requirements.txt file doesn't actually do any required installs, which means that Python had missing dependencies. I made this .sh script to fill in all dependencies, including ones for the scratch-gui server.
Then to keep my fellows penguins happy, I made this .sh script. There is another bug that I'll make a separate report for. |
|
OK, I added some things to the run.py file that will automatically run install/updates. It should be universal, since it uses pip, but the Windows way will still be there should it not work. Hope that works for everyone! cmd = "pip3 install websockets" https://stackoverflow.com/a/51704613try: More pip changes breaking us.main_fn = pipmain DEFAULT_LOGGER = 'rlbot' if name == 'main':
|
LOL, I can't make it look right. |
I am not able to reproduce this, @tarehart we might want to change our approach of how we call pip from python because our current method is not officially supported. See https://stackoverflow.com/a/50255019 |
@kipje13 On Linux Mint? Hmm. Well, I think putting pip in the py file will make it more universal anyways. |
While on linux mint, the browser doesn't open when the match is started.
The text was updated successfully, but these errors were encountered: