Add execFunction : functions can now be ran on clients

[Merudo]

• Add execFunction(functionName,args,defer, targets, delim)
• args is a json array containing the arguments to the function
• defer, targets and delim work as in execLink
• Close Request: execFunction(functionName, args, defer, targets, delim) #790

---

This change is 

[cwisniew]

The context source should not be "Gm", can you change to something else "execFunction" or "remote" is fine. Also can you modify source to follow the formatting standards used throughout the code (like {} braces for if/else) please.

[Phergus]

As Craig noted above, this call in runExecFunction should be changed to not use "Gm" as context source:
MapTool.getParser().runMacroBlock(null, functionText, "execFunction", "Gm", true);

Also a number of if statements without {}.

[Merudo]

What should be the context source, then?

[Phergus]

Craig suggested "execFunction" or "remote".

[Merudo]

Also can you modify source to follow the formatting standards used throughout the code (like {} braces for if/else) please.

What are these formatting standards? I can't find them in the github directory.

[cwisniew]

Also can you modify source to follow the formatting standards used throughout the code (like {} braces for if/else) please.

What are these formatting standards? I can't find them in the github directory.

It seems they are not specifically mentioned (but only in the eclipse file for some reason ugh).

In any case we are using the google java style guide standards with 2 spaces.
https://google.github.io/styleguide/javaguide.html

And I am off to raise an issue about outdated/missing style guide information in the coding standards link on github

[Merudo]

Is there a way to add this to spotlessapply, so it is automatically formatted with the braces?

[Phergus]

I thought it did that already but apparently not.

[cwisniew]

I thought it did to...
but apparently not, google/google-java-format#51
might be time to look for a better way

[Phergus]

Well most IDEs include a code formatting option to handle the if() braces issue.

[Merudo]

I changed the PR and implemented the changes.

[Phergus]

Reviewed 8 of 9 files at r1, 1 of 1 files at r3.
Reviewable status: complete! all files reviewed, all discussions resolved