[🐛BUG] old data format read failed

[panhaoyu]

please check the issue1740.

hello, could you please recheck the issue? seems the issue still exists in 1.1.1

It seems that the code in the repo have fixed the bug, but the pypi package still remain the wrong code. Could you please update the package?

And the code in the current repo still cannot fix the problem for yelp-2022.

Here's my monkey patch, which is only tested for yelp-2022.

def rename_atomic_files(folder, old_name, new_name):
    """Rename all atomic files in a given folder.

    Args:
        folder (string): The folder.
        old_name (string): Old name for atomic files.
        new_name (string): New name for atomic files.
    """
    sub_files = os.listdir(folder)
    sub_files = [f for f in sub_files if f not in ('.DS_Store',)]
    if len(sub_files) == 1:
        sub_dir = os.path.join(folder, sub_files[0])
        if os.path.isdir(sub_dir):
            for sub_file in os.listdir(sub_dir):
                shutil.move(os.path.join(sub_dir, sub_file), os.path.join(folder, sub_file))
            os.rmdir(sub_dir)
    for file in os.listdir(folder):
        base, suf = os.path.splitext(file)
        if old_name not in base:
            continue
        if suf not in {".inter", ".user", ".item"}:
            logger = getLogger()
            logger.warning(f"Moving downloaded file with suffix [{suf}].")
        os.rename(
            os.path.join(folder, file),
            os.path.join(folder, base.replace(old_name, new_name) + suf),
        )


recbole.data.dataset.dataset.rename_atomic_files = rename_atomic_files

[Sherry-XLL]

Hello @panhaoyu, thanks for your suggestions and contributions! We will review your code and fix the bug in time. Thanks again for your continued attention and feedback to RecBole!