Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AixLib.Fluid.HeatExchangers.Radiators.BaseClasses.RadiatorTypes is declared twice causing radiator simulations to fail in Open Modelica Connection Editor #1535

Closed
HenryDore opened this issue Sep 17, 2024 · 2 comments · Fixed by #1536

Comments

@HenryDore
Copy link

Describe the bug
AixLib.Fluid.HeatExchangers.Radiators.BaseClasses.RadiatorTypes is declared twice causing radiator simulations to fail

To Reproduce
Steps to reproduce the behavior:

  1. Load AixLib 2.0.0 in OpenModelica connection editor
  2. Load example AixLib.Fluid.HeatExchangers.Radiators.Examples.Radiator or
  3. Simulate example
  4. See error class already declared

Commit 27df055 "Changed RadiatorTypes from package to .mo File, to eliminate error when opening in OpenModelica" failed to remove directory RadiatorTypes so class gets redeclared, also need to remove duplicate RadiatorTypes line in package.order to fix.

@FWuellhorst
Copy link
Contributor

@HenryDore : PR #1536 fixes this issue, thanks for reporting it. It worked for me locally in OM, can you check if it works for you, as well?

@HenryDore
Copy link
Author

Can confirm it is working for me in OM also 👍 thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants